[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/10] ehci: various fixes
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 00/10] ehci: various fixes |
Date: |
Thu, 15 Nov 2012 13:06:44 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.10) Gecko/20121026 Thunderbird/10.0.10 |
On 11/15/12 12:58, Hans de Goede wrote:
> Hi,
>
> On 11/15/2012 09:55 AM, Gerd Hoffmann wrote:
>> On 11/14/12 17:21, Hans de Goede wrote:
>>> While working on moving usb-redir and usb-hid over to using async packet
>>> handling for their interrupt input endpoints. I've found and fixed quite
>>> a few ehci bugs.
>>>
>>> Unfortunately the moving to async for interrupt endpoints turns out
>>> to be a
>>> bad idea, as it causes issues for migration, an async completed
>>> packet will
>>> not getting written back to guest memory until the next poll time,
>>> and if a
>>> migration happens in between it will get lost!
>>
>> Ok, so it looks like 1-3 are clear bugfixes which are needed in 1.3
>>
>
> Ack, I think that "ehci: Don't verify the next pointer for periodic qh-s"
> belongs in 1.3 too, since this could be hit with host-redirection which
> does use async completion for interrupt endpoints.
>
> Moving it forward in the patch-set will cause a conflict though, I'll go
> and
> do the reshuffle myself, throw in 2 usb-redir fixes and then send a new set
> targetting 1.3.
Thanks.
> Do you also want a separate set on top for 1.4 /
> usb-next, or
> do you want me to keep the rest in my own tree for now ?
Keep it in your tree for now.
cheers,
Gerd
- [Qemu-devel] [PATCH 03/10] ehci: Better detection for qtd-s linked in circles, (continued)
- [Qemu-devel] [PATCH 03/10] ehci: Better detection for qtd-s linked in circles, Hans de Goede, 2012/11/14
- [Qemu-devel] [PATCH 04/10] ehci: Add a ehci_writeback_async_complete_packet helper function, Hans de Goede, 2012/11/14
- [Qemu-devel] [PATCH 05/10] ehci: Add ehci_verify_qh and ehci_verify_qtd helper functions, Hans de Goede, 2012/11/14
- [Qemu-devel] [PATCH 06/10] ehci: Verify guest does not change the token of inflight qtd-s, Hans de Goede, 2012/11/14
- [Qemu-devel] [PATCH 07/10] ehci: Don't verify the next pointer for periodic qh-s, Hans de Goede, 2012/11/14
- [Qemu-devel] [PATCH 08/10] ehci: Move get / put_dwords upwards, Hans de Goede, 2012/11/14
- [Qemu-devel] [PATCH 09/10] ehci: writeback_async_complete_packet: verify qh and qtd, Hans de Goede, 2012/11/14
- [Qemu-devel] [PATCH 10/10] ehci: Verify qtd for async completed packets, Hans de Goede, 2012/11/14
- Re: [Qemu-devel] [PATCH 00/10] ehci: various fixes, Gerd Hoffmann, 2012/11/15