[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 3/3] convert pci-host to QOM
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v5 3/3] convert pci-host to QOM |
Date: |
Thu, 15 Nov 2012 01:55:44 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2 |
Am 08.11.2012 06:36, schrieb Wanpeng Li:
> Take advantage of Andreas's pci-host patchset, add instance_init function
> to fully implement convert pci-host to QOM.
>
> Signed-off-by: Anthony Liguori <address@hidden>
> Signed-off-by: Wanpeng Li <address@hidden>
> ---
> hw/pci_host.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pci_host.c b/hw/pci_host.c
> index 68e328c..ce6b28f 100644
> --- a/hw/pci_host.c
> +++ b/hw/pci_host.c
> @@ -165,11 +165,20 @@ const MemoryRegionOps pci_host_data_be_ops = {
> .endianness = DEVICE_BIG_ENDIAN,
> };
>
> +static void pci_host_initfn(Object *obj)
> +{
> + PCIHostState *s = PCI_HOST_BRIDGE(obj);
> +
> + object_property_add_link(obj, "mmio", "memory-region",
> + (Object **)&s->address_space, NULL);
This strikes me as wrong, unless I've overlooked something in the
previous patches. Also the commit message seems outdated.
Please cc me on the next version, I received no response to my question
about i440fx status and just noticed this now.
Regards,
Andreas
> +}
> +
> static const TypeInfo pci_host_type_info = {
> .name = TYPE_PCI_HOST_BRIDGE,
> .parent = TYPE_SYS_BUS_DEVICE,
> .abstract = true,
> .instance_size = sizeof(PCIHostState),
> + .instance_init = pci_host_initfn,
> };
>
> static void pci_host_register_types(void)
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v5 0/3] refactor PC machine, i440fx and piix3 to take advantage of QOM, Wanpeng Li, 2012/11/08
- [Qemu-devel] [PATCH v5 3/3] convert pci-host to QOM, Wanpeng Li, 2012/11/08
- Re: [Qemu-devel] [PATCH v5 3/3] convert pci-host to QOM,
Andreas Färber <=
- [Qemu-devel] [PATCH v5 1/3] eliminate piix_pci.c and module i440fx and piix3, Wanpeng Li, 2012/11/08
- [Qemu-devel] [PATCH v5 2/3] merge pc_piix.c to pc.c, Wanpeng Li, 2012/11/08
- Re: [Qemu-devel] [PATCH v5 0/3] refactor PC machine, i440fx and piix3 to take advantage of QOM, Wanpeng Li, 2012/11/14