[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/24] qga/channel-posix.c: include headers it n
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 12/24] qga/channel-posix.c: include headers it needs |
Date: |
Wed, 14 Nov 2012 17:14:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2 |
Am 09.11.2012 15:56, schrieb Eduardo Habkost:
> Include:
> - <errno.h> for errno
> - <unistd.h> & <fcntl.h> for fcntl()
> - "qemu-stdio.h" for qemu_open()
>
> Some of those headers were probably being included by accident because
> some other headers were including qemu-common.h, but those headers
> should eventually stop including qemu-common.h.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> qga/channel-posix.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/qga/channel-posix.c b/qga/channel-posix.c
> index d152827..2a68451 100644
> --- a/qga/channel-posix.c
> +++ b/qga/channel-posix.c
> @@ -1,5 +1,9 @@
> #include <glib.h>
> #include <termios.h>
> +#include <errno.h>
> +#include <unistd.h>
> +#include <fcntl.h>
> +#include "qemu-stdio.h"
> #include "qemu_socket.h"
> #include "qga/channel.h"
>
Since the qemu-stdio.h patch was under debate, I've posted a patch
moving qemu_open() and its companion qemu_close() to osdep.h as
suggested by Igor - uses osdep.h here works fine then. Rest looks good.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 00/24] CPU DeviceState v7, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 02/24] user: rename qemu-types.h to qemu-user-types.h, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 15/24] qlist.h: do not include qemu-common.h, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 20/24] qdev: add weak aliases for vmstate handling on qdev.c, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 12/24] qga/channel-posix.c: include headers it needs, Eduardo Habkost, 2012/11/09
- Re: [Qemu-devel] [PATCH 12/24] qga/channel-posix.c: include headers it needs,
Andreas Färber <=
- [Qemu-devel] [PATCH 07/24] qemu-fsdev-dummy.c: include module.h, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 23/24] include qdev code into *-user, too, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 24/24] qom: make CPU a child of DeviceState, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 14/24] sysemu.h: include qemu-types.h instead of qemu-common.h, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 16/24] qapi-types.h: don't include qemu-common.h, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 21/24] qdev: add weak alias to sysbus_get_default() on qdev.c, Eduardo Habkost, 2012/11/09