Re: [Qemu-devel] [PATCH 05/22] console: untangle gfx & txt updates

[Peter Maydell]

On 2 November 2012 08:20, Jan Kiszka <address@hidden> wrote:
> On 2012-11-01 14:04, Gerd Hoffmann wrote:
>> Stop abusing displaysurface fields for text mode displays.
>> (bpp = 0, width = cols, height = lines).
>>
>> Add flags to displaystate indicating whenever text mode display
>> (curses) or gfx mode displays (sdl, vnc, ...) are present.
>>
>> Add separate displaychangelistener callbacks for text / gfx mode
>> resize & updates.
>>
>> This allows to enable gfx and txt diplays at the same time and also
>> paves the way for more cleanups in the future.
>
> Breaks building xenfb.c.

Also breaks building the Cocoa frontend on MacOS:

  OBJC  ui/cocoa.o
ui/cocoa.m:771:10: warning:
      
'beginSheetForDirectory:file:types:modalForWindow:modalDelegate:didEndSelector:contextInfo:'
is
      deprecated [-Wdeprecated-declarations]
        [op beginSheetForDirectory:nil file:nil types:[NSArray ...
         ^
ui/cocoa.m:810:32: warning: 'filename' is deprecated [-Wdeprecated-declarations]
        char *img = (char*)[ [ sheet filename ]
cStringUsingEncoding:NSASCIIStringEncoding];
                               ^
ui/cocoa.m:1020:10: error: no member named 'dpy_update' in 'struct
DisplayChangeListener'
    dcl->dpy_update = cocoa_update;
    ~~~  ^
ui/cocoa.m:1021:10: error: no member named 'dpy_resize' in 'struct
DisplayChangeListener'
    dcl->dpy_resize = cocoa_resize;
    ~~~  ^
2 warnings and 2 errors generated.
make: *** [ui/cocoa.o] Error 1

'git grep dpy_update' suggests that xenfb and cocoa are the only two
breakages though.


-- PMM