[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: Reject non-netdevs in qmp_netdev_del()
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] net: Reject non-netdevs in qmp_netdev_del() |
Date: |
Thu, 1 Nov 2012 11:06:26 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Oct 24, 2012 at 02:34:12PM +0200, Stefan Hajnoczi wrote:
> The netdev_del command crashes when given a -net device, because it
> calls qemu_opts_del(NULL).
>
> Check that this is a -netdev before attempting to delete it and the
> QemuOpts.
>
> Note the subtle change from qemu_find_opts_err("netdev", errp) to
> qemu_find_opts_err("netdev", NULL). Since "netdev" is a built in
> options group and we don't check for NULL return anyway, there's no use
> in passing errp here.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> net.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
Applied to the net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] net: Reject non-netdevs in qmp_netdev_del(),
Stefan Hajnoczi <=