[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] disallow -daemonize usage of stdio (curses disp
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] disallow -daemonize usage of stdio (curses display, -nographic, -serial stdio etc) |
Date: |
Mon, 29 Oct 2012 10:18:41 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Oct 27, 2012 at 05:15:15PM +0400, Michael Tokarev wrote:
> diff --git a/vl.c b/vl.c
> index 9f99ef4..db48d62 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3413,6 +3413,26 @@ int main(int argc, char **argv, char **envp)
> default_sdcard = 0;
> }
>
> + if (is_daemonized()) {
> + /* According to documentation and historically, -nographic redirects
> + * serial port, parallel port and monitor to stdio, which does not
> work
> + * with -daemonize. We can redirect these to null instead, but since
> + * -nographic is legacy, let's just error out.
> + */
> + if (display_type == DT_NOGRAPHIC
> + /* && (default_parallel || default_serial
> + || default_monitor || default_virtcon) */) {
Uncomment these?
Stefan