|
From: | Markus Armbruster |
Subject: | Re: [Qemu-devel] [PATCH 0/7] ARM boards: don't prematurely explode QEMUMachineInitArgs |
Date: | Wed, 24 Oct 2012 10:42:55 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Peter Maydell <address@hidden> writes: > A lot of the ARM board models follow the pattern of having a > single common init function which is called with various > parameters from the QEMUMachine init function for several board > model variants. The change to QEMUMachineInitArgs in commit 5f072e > took the fairly mechanical approach of splitting the QEMUMachineInitArgs > fields out in each variant's init function to pass to an unchanged > common init function. This is a bit repetitive, so clean them up > to just pass the QEMUMachineInitArgs directly to the common > function instead. A quick grep finds similar cleanup opportunities in hw/exynos4_boards.c exynos4_boards_init_common() hw/pc_piix.c pc_init1() hw/sun4m.c sun4m_hw_init() hw/sun4u.c sun4uv_init() hw/xtensa_lx60.c lx_init() hw/xtensa_sim.c sim_init()
[Prev in Thread] | Current Thread | [Next in Thread] |