[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard command
From: |
Nicholas Thomas |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server |
Date: |
Tue, 23 Oct 2012 12:08:39 +0100 |
On Tue, 2012-10-23 at 12:33 +0200, Kevin Wolf wrote:
> Am 22.10.2012 13:09, schrieb address@hidden:
> >
> > This is unlikely to come up now, but is a necessary prerequisite for
> > reconnection
> > behaviour.
> >
> > Signed-off-by: Nick Thomas <address@hidden>
> > ---
> > block/nbd.c | 13 +++++++++++--
> > 1 files changed, 11 insertions(+), 2 deletions(-)
>
> What's the real requirement here? Silently ignoring a flush and
> returning success for it feels wrong. Why is it correct?
>
> Kevin
I just needed to avoid socket operations while s->sock == -1, and
extending the existing case of "can't do the command, so pretend I did
it" to "can't do the command right now, so pretend..." seemed like an
easy way out.
In the Bytemark case, the NBD server always opens the file O_SYNC, so
nbd_co_flush could check in_flight == 0 and return 0/1 based on that;
but I'd be surprised if that's true for all NBD servers. Should we be
returning 1 here for both "not supported" and "can't do it right now",
instead?
/Nick
- [Qemu-devel] [PATCH 0/3] NBD reconnection behaviour, nick, 2012/10/22
- [Qemu-devel] [PATCH 3/3] nbd: Move reconnection attempts from each new I/O request to a 5-second timer, nick, 2012/10/22
- [Qemu-devel] [PATCH 2/3] nbd: Explicitly disconnect and fail inflight I/O requests on error, then reconnect next I/O request., nick, 2012/10/22
- [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server, nick, 2012/10/22
- Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server, Kevin Wolf, 2012/10/23
- Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server,
Nicholas Thomas <=
- Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server, Kevin Wolf, 2012/10/23
- Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server, Jamie Lokier, 2012/10/23
- Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server, Nicholas Thomas, 2012/10/24
- Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server, Kevin Wolf, 2012/10/24
- Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server, Jamie Lokier, 2012/10/24
- Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server, Paolo Bonzini, 2012/10/24
- Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server, Kevin Wolf, 2012/10/25
- Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server, Jamie Lokier, 2012/10/25
- Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server, Kevin Wolf, 2012/10/26
- Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server, Paolo Bonzini, 2012/10/24