Re: [Qemu-devel] [PATCH 2/3] nbd: Explicitly disconnect and fail inflight I/O requests on error, then reconnect next I/O request.

[Kevin Wolf]

Am 22.10.2012 13:09, schrieb address@hidden:
> 
> The previous behaviour when an NBD connection broke was to fail just the 
> broken I/O request
> and (sometimes) never unlock send_mutex. Now we explicitly call 
> nbd_teardown_connection and
> fail all NBD requests in the "inflight" state - this allows werror/rerror 
> settings to be
> applied to those requests all at once.
> 
> When a new request (or a request that was pending, but not yet inflight) is 
> issued against
> the NBD driver, if we're not connected to the NBD server, we attempt to 
> connect (and fail
> the new request immediately if that doesn't work). 

Doesn't this block the vcpu while qemu is trying to establish a new
connection? When the network is down, I think this can take quite a
while. I would actually expect that this is one of the cases where qemu
as a whole would seem to hang.

Kevin