Re: [Qemu-devel] [PATCH v3 17/26] Add i21154 bridge chip.

[Andreas Färber]

Am 19.10.2012 22:43, schrieb Jason Baron:
> From: Jason Baron <address@hidden>
> 
> This adds support for the DECchip 21154 PCI bridge.
> 
> Signed-off-by: Isaku Yamahata <address@hidden>
> Signed-off-by: Jason Baron <address@hidden>
> ---
>  hw/Makefile.objs |    2 +-
>  hw/i21154.c      |  113 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/i21154.h      |    9 ++++
>  3 files changed, 123 insertions(+), 1 deletions(-)
>  create mode 100644 hw/i21154.c
>  create mode 100644 hw/i21154.h

Why is this creating a new file and not reusing dec_pci.c? We shouldn't
have two parallel implementations of the same chip.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg