Re: [Qemu-devel] [PATCH 23/25] block: add close notifiers

[Paolo Bonzini]

> > @@ -1098,12 +1106,13 @@ void bdrv_reopen_abort(BDRVReopenState 
> > *reopen_state)
> >  void bdrv_close(BlockDriverState *bs)
> >  {
> >      bdrv_flush(bs);
> > -    if (bs->drv) {
> > -        if (bs->job) {
> > -            block_job_cancel_sync(bs->job);
> > -        }
> > -        bdrv_drain_all();
> > +    if (bs->job) {
> > +        block_job_cancel_sync(bs->job);
> > +    }
> > +    bdrv_drain_all();
> 
> Dropping the bs->drv condition in a separate commit gives you a nice
> place to explain why it's fine: the commit message.  I figure it is,
> but it's not 100% obvious.

Will do, thanks.

Paolo