Re: [Qemu-devel] [PATCH V3] e1000: drop check_rxov, always treat RX ring with RDH == RDT as empty

[Dmitry Fleytman]

Thanks Stefan,

It was my very first idea to drop check_rxov and solve the problem,
however for some reason I was sure that it required to emulate real HW behavior.

I'm glad we clarified this.

Regards,
Dmitry Fleytman

On Fri, Oct 19, 2012 at 9:52 AM, Stefan Hajnoczi <address@hidden> wrote:
> On Fri, Oct 19, 2012 at 07:56:55AM +0200, Dmitry Fleytman wrote:
>> Real HW always treats RX ring with RDH == RDT as empty.
>> Emulation is supposed to behave the same.
>>
>> Reported-by: Chris Webb <address@hidden>
>> Reported-by: Richard Davies <address@hidden>
>> Signed-off-by: Dmitry Fleytman <address@hidden>
>> ---
>>  hw/e1000.c | 7 ++-----
>>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> Applied to the net tree:
> http://github.com/stefanha/qemu/commits/net
>
> Thanks for your efforts in squashing this bug!  Glad it was possible to
> drop check_rxov.
>
> Stefan



-- 
Dmitry Fleytman
Technology Expert and Consultant,

Daynix Computing Ltd.

Cell: +972-54-2819481

Skype: dmitry.fleytman