[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/8] block: bdrv_img_create(): move parameter li
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 3/8] block: bdrv_img_create(): move parameter list printing to qemu-img |
Date: |
Thu, 18 Oct 2012 10:34:47 -0300 |
On Thu, 18 Oct 2012 14:16:43 +0200
Kevin Wolf <address@hidden> wrote:
> Am 18.10.2012 14:01, schrieb Kevin Wolf:
> > Am 17.10.2012 21:35, schrieb Luiz Capitulino:
> >> Today, bdrv_img_create() prints the parameter list used to create the
> >> new image to stdout, like this:
> >>
> >> Formatting '/tmp/a', fmt=qcow2 size=10737418240 encryption=off
> >> cluster_size=65536 lazy_refcounts=off
> >>
> >> As the transaction QMP command calls bdrv_img_create(), this message
> >> is also printed when using QMP.
> >>
> >> This commit moves the printing of the parameter list to qemu-img instead.
> >> This way we avoid printing it in QMP and from whatever bdrv_img_create()
> >> usage we might have in the future.
> >>
> >> Signed-off-by: Luiz Capitulino <address@hidden>
> >
> > I believe the idea was that this message is printed before actually
> > creating the image, which in the case of preallocation could take a while.
>
> The other thing is that I think you don't print the message any more
> when creating the image fails. Did you check that qemu-iotests doesn't
> need any updates?
I didn't. But I'll preserve today's behavior for v2 as I mentioned in my
last email.
- Re: [Qemu-devel] [PATCH 2/8] block: bdrv_img_create(): add param_list argument, (continued)
[Qemu-devel] [PATCH 1/8] error: add error_set_errno and error_setg_errno, Luiz Capitulino, 2012/10/17
[Qemu-devel] [PATCH 4/8] block: bdrv_img_create(): add Error ** argument, Luiz Capitulino, 2012/10/17
[Qemu-devel] [PATCH 3/8] block: bdrv_img_create(): move parameter list printing to qemu-img, Luiz Capitulino, 2012/10/17
[Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object, Luiz Capitulino, 2012/10/17
- Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object, Kevin Wolf, 2012/10/18
- Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object, Luiz Capitulino, 2012/10/18
- Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object, Kevin Wolf, 2012/10/18
- Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object, Markus Armbruster, 2012/10/23
- Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object, Kevin Wolf, 2012/10/23
- Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object, Luiz Capitulino, 2012/10/23
[Qemu-devel] [PATCH 7/8] qmp: qmp_transaction(): pass Error object to bdrv_img_create(), Luiz Capitulino, 2012/10/17
[Qemu-devel] [PATCH 6/8] qemu-img: img_create(): simplify, Luiz Capitulino, 2012/10/17
[Qemu-devel] [PATCH 8/8] block: bdrv_img_create(): drop unused error handling code, Luiz Capitulino, 2012/10/17