[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support.
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support. |
Date: |
Wed, 17 Oct 2012 09:26:17 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 |
On 10/17/2012 04:09 AM, Gerd Hoffmann wrote:
> This patch adds chardev_add and chardev_remove monitor commands.
>
> They work similar to the netdev_{add,del} commands. The hmp version of
> chardev_add accepts like the -chardev command line option does. The qmp
> version expects the arguments being passed as named parameters.
>
> chardev_del just takes an id argument and zaps the chardev specified.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> +##
> +# @chardev-add:
> +#
> +# Add a chardev
> +#
> +# @id: the chardev's ID, must be unique
> +# @backend: the chardev backend: "file", "socket", ...
This still needs to be an enum.
> +# @path: file / device / unix socket path
> +# @name: spice channel name
> +# @host: host name
> +# @port: port number
> +# @server: create socket in server mode
> +# @wait: wait for connect
> +# @ipv4: force ipv4-only
> +# @ipv6: force ipv6-only
> +# @telnet: telnet negotiation
But this part looks nicer.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature