Re: [Qemu-devel] [PATCH 13/22] usb: Add an int_req flag to USBPacket

[Hans de Goede]

Hi,

On 10/17/2012 01:04 PM, Gerd Hoffmann wrote:
> On 10/15/12 12:38, Hans de Goede wrote:
> > -    usb_packet_setup(&xfer->packet, dir, ep, xfer->trbs[0].addr, false);
> > +    int_req = false;
> > +    for (i = 0; i < xfer->trb_count; i++) {
> > +        if (xfer->trbs[i].control & TRB_TR_IOC) {
> > +            int_req = true;
> > +            break;
> > +        }
> > +    }
>
> Guess we better add a new int_req field to XHCITransfer and fill it when
> walking the trb list _anyway_, so we don't have to loop again.

Ok, I will fix this for the next respin of the patchset.

Regards,

Hans