qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 0/4] block-commit fixes


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 0/4] block-commit fixes
Date: Tue, 16 Oct 2012 14:33:02 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0

On 10/16/2012 01:49 PM, Jeff Cody wrote:
> v2 -> v3 differences:
> 
> * Simplified code in patch 2, minor commit rewording
> * Made conditional check more valgrind-friendly
> 
> v1 -> v2 differences:
> 
> * Updated changes to be protocol friendly
> * Updated block-commit tests to account for different error message
>   wording
> * Updated block-commit tests to add relative backing filename tests
> * In bdrv_find_backing_image(), use g_malloc() instead of char arrays
> 
> 
> Jeff Cody (4):
>   block: make bdrv_find_backing_image compare canonical filenames
>   block: in commit, determine base image from the top image
>   qemu-iotests: qemu-io tests update for block-commit (040)
>   qemu-iotests: add relative backing file tests for block-commit (040)

Should patch 3/4 be squashed into 2/4 to avoid 'git bisect' failures
when running the testsuite?  Other than that, series:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]