Re: [Qemu-devel] [RFC] [PATCH 0/5] linux-user: refactor do_syscall()

[Peter Maydell]

On 12 October 2012 21:47, Richard Henderson <address@hidden> wrote:
> On 10/12/2012 11:24 AM, address@hidden wrote:
>> As the first step of the cleanup, I'd like to move implementation of each 
>> syscall
>> completely to their own functions. While at it, we define more standard 
>> interface between
>> do_syscall() and the functions implementing the system calls: system call 
>> functions take
>> parameter as raw abi_long, and leave the host to target errno conversion to 
>> do_syscall.
>
> My only concern is leaving the host-to-target conversion to do_syscall.
> I think the return value from do_foo should be the proper target return value.

Yes, I think I agree with this.

Also, maybe we should have all the do_foo() functions actually have the
same signature (ie take all 6 args)? Otherwise when we switch to the
dispatch-via-function-pointer-in-array-of-structs model we'll have to
change all those prototypes first.

-- PMM