[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support. |
Date: |
Fri, 12 Oct 2012 13:15:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.8) Gecko/20121006 Thunderbird/10.0.8 |
On 10/12/12 12:50, Paolo Bonzini wrote:
> Il 12/10/2012 12:23, Gerd Hoffmann ha scritto:
>>> I suggest that you implement the commands in a similar way as netdev_add.
>>
>> Why? Isn't the whole point of using josn is that you'll get the stuff
>> from the josn parser & marshaller in a usable form instead of having it
>> to feed into yet another parser? I think the only reason netdev_add
>> exists in the current form is that it predates qmp.
>
> In principle you're right, but I think it's ugly that adding another
> chardev argument needs changes in 3 places instead of just one.
Hmm, I don't have to use the generated marshaller, right? With direct
access to the QDict I could just transform it into a QemuOpts. A new
parameter wouldn't need code changes then. And the code would be
reusable and probably also be simpler. The qapi schema still needs an
update though.
HMP is more tricky, but I think we should sort QMP first.
cheers,
Gerd
- [Qemu-devel] [PULL 0/7] serial device hotplug patch series., Gerd Hoffmann, 2012/10/12
- [Qemu-devel] [PATCH 5/7] usb-serial: don't magically zap chardev on umplug, Gerd Hoffmann, 2012/10/12
- [Qemu-devel] [PATCH 7/7] chardev: add hotplug support., Gerd Hoffmann, 2012/10/12
- Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support., Paolo Bonzini, 2012/10/12
- Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support., Gerd Hoffmann, 2012/10/12
- Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support., Paolo Bonzini, 2012/10/12
- Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support., Paolo Bonzini, 2012/10/12
- Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support., Gerd Hoffmann, 2012/10/12
- [Qemu-devel] [PATCH v2] chardev: add hotplug support., Gerd Hoffmann, 2012/10/12
- Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support., Gerd Hoffmann, 2012/10/12
- Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support., Paolo Bonzini, 2012/10/12
- Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support., Paolo Bonzini, 2012/10/12
- Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support., Lei Li, 2012/10/15
- Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support., Andreas Färber, 2012/10/15
- Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support., Luiz Capitulino, 2012/10/16
- Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support., Eric Blake, 2012/10/15