[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/7] usb-serial: only expose device in guest when th
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 6/7] usb-serial: only expose device in guest when the chardev is open |
Date: |
Fri, 12 Oct 2012 11:26:01 +0200 |
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb/dev-serial.c | 19 +++++++++++++++++--
1 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c
index 43214cd..a466f99 100644
--- a/hw/usb/dev-serial.c
+++ b/hw/usb/dev-serial.c
@@ -427,6 +427,10 @@ static void usb_serial_handle_destroy(USBDevice *dev)
static int usb_serial_can_read(void *opaque)
{
USBSerialState *s = opaque;
+
+ if (!s->dev.attached) {
+ return 0;
+ }
return RECV_BUF - s->recv_used;
}
@@ -469,8 +473,14 @@ static void usb_serial_event(void *opaque, int event)
case CHR_EVENT_FOCUS:
break;
case CHR_EVENT_OPENED:
- usb_serial_reset(s);
- /* TODO: Reset USB port */
+ if (!s->dev.attached) {
+ usb_device_attach(&s->dev);
+ }
+ break;
+ case CHR_EVENT_CLOSED:
+ if (s->dev.attached) {
+ usb_device_detach(&s->dev);
+ }
break;
}
}
@@ -481,6 +491,7 @@ static int usb_serial_initfn(USBDevice *dev)
usb_desc_create_serial(dev);
usb_desc_init(dev);
+ dev->auto_attach = 0;
if (!s->cs) {
error_report("Property chardev is required");
@@ -490,6 +501,10 @@ static int usb_serial_initfn(USBDevice *dev)
qemu_chr_add_handlers(s->cs, usb_serial_can_read, usb_serial_read,
usb_serial_event, s);
usb_serial_handle_reset(dev);
+
+ if (s->cs->opened && !dev->attached) {
+ usb_device_attach(dev);
+ }
return 0;
}
--
1.7.1
- Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support., (continued)
- Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support., Paolo Bonzini, 2012/10/12
- Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support., Gerd Hoffmann, 2012/10/12
- Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support., Paolo Bonzini, 2012/10/12
- Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support., Gerd Hoffmann, 2012/10/12
- [Qemu-devel] [PATCH v2] chardev: add hotplug support., Gerd Hoffmann, 2012/10/12
- Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support., Gerd Hoffmann, 2012/10/12
- Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support., Paolo Bonzini, 2012/10/12
- Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support., Paolo Bonzini, 2012/10/12
[Qemu-devel] [PATCH 1/7] serial: split serial.c, Gerd Hoffmann, 2012/10/12
[Qemu-devel] [PATCH 3/7] serial: add windows inf file for the pci card to docs, Gerd Hoffmann, 2012/10/12
[Qemu-devel] [PATCH 6/7] usb-serial: only expose device in guest when the chardev is open,
Gerd Hoffmann <=
[Qemu-devel] [PATCH 4/7] serial: add 2x + 4x pci variant, Gerd Hoffmann, 2012/10/12
[Qemu-devel] [PATCH 2/7] serial: add pci variant, Gerd Hoffmann, 2012/10/12
Re: [Qemu-devel] [PULL 0/7] serial device hotplug patch series., Paolo Bonzini, 2012/10/12