[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-sparc: Fix optimized %icc comparisons
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] target-sparc: Fix optimized %icc comparisons |
Date: |
Mon, 8 Oct 2012 19:20:10 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Oct 08, 2012 at 08:42:03AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target-sparc/translate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> This should fix the boot problem that Aurelien saw. It also showed
> up in some userland speed testing I'm trying to set up (cross gcc).
>
>
I confirm it fixes the issue I reported.
Tested-by: Aurelien Jarno <address@hidden>
> diff --git a/target-sparc/translate.c b/target-sparc/translate.c
> index 472eb51..71b9d65 100644
> --- a/target-sparc/translate.c
> +++ b/target-sparc/translate.c
> @@ -1120,6 +1120,7 @@ static void gen_compare(DisasCompare *cmp, bool xcc,
> unsigned int cond,
> cmp->c2 = tcg_temp_new();
> tcg_gen_ext32s_tl(cmp->c1, cpu_cc_src);
> tcg_gen_ext32s_tl(cmp->c2, cpu_cc_src2);
> + break;
> }
> #endif
> cmp->g1 = cmp->g2 = true;
> --
> 1.7.11.4
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net