[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/14] i386: change gen_setcc_slow_T0 to gen_set
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 12/14] i386: change gen_setcc_slow_T0 to gen_setcc_slow |
Date: |
Sun, 7 Oct 2012 19:36:30 +0000 |
On Sat, Oct 6, 2012 at 12:30 PM, Paolo Bonzini <address@hidden> wrote:
> Do not hard code the destination register.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Blue Swirl <address@hidden>
> ---
> target-i386/translate.c | 39 ++++++++++++++++++++-------------------
> 1 file modificato, 20 inserzioni(+), 19 rimozioni(-)
>
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index 4561c9d..fb44839 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -1016,50 +1016,51 @@ static void gen_compute_eflags_z(DisasContext *s,
> TCGv reg, bool inv)
> }
> }
>
> -static inline void gen_setcc_slow_T0(DisasContext *s, int jcc_op, bool inv)
> +static inline void gen_setcc_slow(DisasContext *s, int jcc_op, TCGv reg,
> bool inv)
> {
> + assert(reg != cpu_cc_src);
> switch(jcc_op) {
> case JCC_O:
> - gen_compute_eflags_o(s, cpu_T[0]);
> + gen_compute_eflags_o(s, reg);
> break;
> case JCC_B:
> - gen_compute_eflags_c(s, cpu_T[0], inv);
> + gen_compute_eflags_c(s, reg, inv);
> return;
> case JCC_Z:
> - gen_compute_eflags_z(s, cpu_T[0], inv);
> + gen_compute_eflags_z(s, reg, inv);
> return;
> case JCC_BE:
> gen_compute_eflags(s);
> - tcg_gen_shri_tl(cpu_T[0], cpu_cc_src, 6);
> - tcg_gen_or_tl(cpu_T[0], cpu_T[0], cpu_cc_src);
> - tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 1);
> + tcg_gen_shri_tl(reg, cpu_cc_src, 6);
> + tcg_gen_or_tl(reg, reg, cpu_cc_src);
> + tcg_gen_andi_tl(reg, reg, 1);
> break;
> case JCC_S:
> - gen_compute_eflags_s(s, cpu_T[0], inv);
> + gen_compute_eflags_s(s, reg, inv);
> return;
> case JCC_P:
> - gen_compute_eflags_p(s, cpu_T[0]);
> + gen_compute_eflags_p(s, reg);
> break;
> case JCC_L:
> gen_compute_eflags(s);
> - tcg_gen_shri_tl(cpu_T[0], cpu_cc_src, 11); /* CC_O */
> + tcg_gen_shri_tl(reg, cpu_cc_src, 11); /* CC_O */
> tcg_gen_shri_tl(cpu_tmp0, cpu_cc_src, 7); /* CC_S */
> - tcg_gen_xor_tl(cpu_T[0], cpu_T[0], cpu_tmp0);
> - tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 1);
> + tcg_gen_xor_tl(reg, reg, cpu_tmp0);
> + tcg_gen_andi_tl(reg, reg, 1);
> break;
> default:
> case JCC_LE:
> gen_compute_eflags(s);
> - tcg_gen_shri_tl(cpu_T[0], cpu_cc_src, 11); /* CC_O */
> + tcg_gen_shri_tl(reg, cpu_cc_src, 11); /* CC_O */
> tcg_gen_shri_tl(cpu_tmp4, cpu_cc_src, 7); /* CC_S */
> tcg_gen_shri_tl(cpu_tmp0, cpu_cc_src, 6); /* CC_Z */
> - tcg_gen_xor_tl(cpu_T[0], cpu_T[0], cpu_tmp4);
> - tcg_gen_or_tl(cpu_T[0], cpu_T[0], cpu_tmp0);
> - tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 1);
> + tcg_gen_xor_tl(reg, reg, cpu_tmp4);
> + tcg_gen_or_tl(reg, reg, cpu_tmp0);
> + tcg_gen_andi_tl(reg, reg, 1);
> break;
> }
> if (inv) {
> - tcg_gen_xori_tl(cpu_T[0], cpu_T[0], 1);
> + tcg_gen_xori_tl(reg, reg, 1);
> }
> }
>
> @@ -1226,7 +1227,7 @@ static inline void gen_jcc1(DisasContext *s, int b, int
> l1)
> break;
> default:
> slow_jcc:
> - gen_setcc_slow_T0(s, jcc_op, false);
> + gen_setcc_slow(s, jcc_op, cpu_T[0], false);
> tcg_gen_brcondi_tl(inv ? TCG_COND_EQ : TCG_COND_NE,
> cpu_T[0], 0, l1);
> break;
> @@ -2497,7 +2498,7 @@ static void gen_setcc(DisasContext *s, int b)
> worth to */
> inv = b & 1;
> jcc_op = (b >> 1) & 7;
> - gen_setcc_slow_T0(s, jcc_op, inv);
> + gen_setcc_slow(s, jcc_op, cpu_T[0], inv);
> }
> }
>
> --
> 1.7.12.1
>
>
>
- Re: [Qemu-devel] [PATCH 08/14] i386: do not compute eflags multiple times consecutively, (continued)
- [Qemu-devel] [PATCH 05/14] i386: move eflags computation closer to gen_op_set_cc_op, Paolo Bonzini, 2012/10/06
- [Qemu-devel] [PATCH 10/14] i386: use inverted setcond when computing NS or NZ, Paolo Bonzini, 2012/10/06
- [Qemu-devel] [PATCH 13/14] i386: optimize setbe, Paolo Bonzini, 2012/10/06
- [Qemu-devel] [PATCH 12/14] i386: change gen_setcc_slow_T0 to gen_setcc_slow, Paolo Bonzini, 2012/10/06
- [Qemu-devel] [PATCH 11/14] i386: convert gen_compute_eflags_c to TCG, Paolo Bonzini, 2012/10/06
- [Qemu-devel] [PATCH 14/14] i386: optimize setcc instructions, Paolo Bonzini, 2012/10/06