[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditiona
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally |
Date: |
Sun, 07 Oct 2012 15:16:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 10/05/2012 06:45 PM, Peter Maydell wrote:
> On 4 October 2012 11:36, Avi Kivity <address@hidden> wrote:
>> diff --git a/targphys.h b/targphys.h
>> index bd4938f..08cade9 100644
>> --- a/targphys.h
>> +++ b/targphys.h
>> @@ -3,25 +3,10 @@
>> #ifndef TARGPHYS_H
>> #define TARGPHYS_H
>>
>> -#ifdef TARGET_PHYS_ADDR_BITS
>> +#define TARGET_PHYS_ADDR_BITS 64
>> /* target_phys_addr_t is the type of a physical address (its size can
>> be different from 'target_ulong'). */
>
> I've just noticed that this change means that linux-user binaries
> now get a definition of target_phys_addr_t (where previously they
> did not get that type at all). Was this intentional,
No.
> and does it make sense?
Not much. Not very harmful either. If you want it removed, I can post
a patch.
--
error compiling committee.c: too many arguments to function
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, (continued)
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Anthony Liguori, 2012/10/04
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Blue Swirl, 2012/10/04
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Michael Walle, 2012/10/04
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Stefan Weil, 2012/10/04
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Anthony Liguori, 2012/10/04
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Peter Maydell, 2012/10/05
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally,
Avi Kivity <=