[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch 5/7] Emulate qemu-kvms drive parameter boot=on|o
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [patch 5/7] Emulate qemu-kvms drive parameter boot=on|off |
Date: |
Fri, 05 Oct 2012 19:24:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-10-05 19:13, Marcelo Tosatti wrote:
> From: Jan Kiszka <address@hidden>
>
> Releases of qemu-kvm will be interrupted at qemu 1.3.0.
> Users should switch to plain qemu releases.
> To avoid breaking scenarios which are setup with command line
> options specific to qemu-kvm, port these switches from qemu-kvm
> to qemu.git.
>
> Port drive boot option. From the qemu-kvm original commit message:
>
> We do not want to maintain this option forever. It will be removed after
> a grace period of a few releases. So warn the user that this option has
> no effect and will become invalid soon.
>
> Signed-off-by: Marcelo Tosatti <address@hidden>
>
> Index: qemu-compat-kvm/blockdev.c
> ===================================================================
> --- qemu-compat-kvm.orig/blockdev.c
> +++ qemu-compat-kvm/blockdev.c
> @@ -432,6 +432,12 @@ DriveInfo *drive_init(QemuOpts *opts, in
> return NULL;
> }
>
> + if (qemu_opt_get(opts, "boot") != NULL) {
> + fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and will be "
> + "ignored. Future versions will reject this parameter. Please
> "
> + "update your scripts.\n");
> + }
> +
> on_write_error = BLOCK_ERR_STOP_ENOSPC;
> if ((buf = qemu_opt_get(opts, "werror")) != NULL) {
> if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO && type
> != IF_NONE) {
> Index: qemu-compat-kvm/qemu-config.c
> ===================================================================
> --- qemu-compat-kvm.orig/qemu-config.c
> +++ qemu-compat-kvm/qemu-config.c
> @@ -114,6 +114,10 @@ static QemuOptsList qemu_drive_opts = {
> .name = "copy-on-read",
> .type = QEMU_OPT_BOOL,
> .help = "copy read data from backing file into image file",
> + },{
> + .name = "boot",
> + .type = QEMU_OPT_BOOL,
> + .help = "(deprecated, ignored)",
> },
> { /* end of list */ }
> },
>
>
Same as with patch 3: nothing is emulated, only a warning issued.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
- [Qemu-devel] [patch 3/7] Use machine options to emulate -no-kvm-pit, (continued)
- [Qemu-devel] [patch 1/7] cirrus_vga: allow configurable vram size, Marcelo Tosatti, 2012/10/05
- [Qemu-devel] [patch 7/7] Emulate qemu-kvms -no-kvm option, Marcelo Tosatti, 2012/10/05
- [Qemu-devel] [patch 6/7] Emulate qemu-kvms -tdf option, Marcelo Tosatti, 2012/10/05
- [Qemu-devel] [patch 4/7] Use global properties to emulate -no-kvm-pit-reinjection, Marcelo Tosatti, 2012/10/05
- [Qemu-devel] [patch 5/7] Emulate qemu-kvms drive parameter boot=on|off, Marcelo Tosatti, 2012/10/05
- Re: [Qemu-devel] [patch 5/7] Emulate qemu-kvms drive parameter boot=on|off,
Jan Kiszka <=
- Re: [Qemu-devel] [patch 0/7] qemu-kvm compat (v2), Jan Kiszka, 2012/10/05