[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v1 03/22] kvm: use separate MemoryListeners for me
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [RFC v1 03/22] kvm: use separate MemoryListeners for memory and I/O |
Date: |
Thu, 04 Oct 2012 18:58:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 10/04/2012 06:44 PM, Blue Swirl wrote:
> On Thu, Oct 4, 2012 at 6:33 AM, Avi Kivity <address@hidden> wrote:
>> On 10/03/2012 10:16 PM, Blue Swirl wrote:
>>> > +static MemoryListener kvm_io_listener = {
>>>
>>> const
>>>
>>
>> There is a list link field in there. It's a mixed data/ops structure
>> (perhaps we should make it a traditional ->ops-> pointer).
>
> I grepped for MemoryListener and in hw/xen_pt.c 'const' already
> exists, so it looked OK but the code actually copies the structure to
> writable memory.
Yes. We should probably switch to the standard object->ops->callback
pattern. I'll write a patch after this series is merged.
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [RFC v1 01/22] memory: rename 'exec-obsolete.h', (continued)
- [Qemu-devel] [RFC v1 01/22] memory: rename 'exec-obsolete.h', Avi Kivity, 2012/10/03
- [Qemu-devel] [RFC v1 02/22] vhost: use MemoryListener filtering to only monitor RAM address space, Avi Kivity, 2012/10/03
- [Qemu-devel] [RFC v1 05/22] memory: prepare AddressSpace for exporting, Avi Kivity, 2012/10/03
- [Qemu-devel] [RFC v1 04/22] xen_pt: use separate MemoryListeners for memory and I/O, Avi Kivity, 2012/10/03
- [Qemu-devel] [RFC v1 03/22] kvm: use separate MemoryListeners for memory and I/O, Avi Kivity, 2012/10/03
[Qemu-devel] [RFC v1 09/22] memory: use new MEMORY_LISTENER_DEFAULT_OPS, Avi Kivity, 2012/10/03
[Qemu-devel] [RFC v1 06/22] memory: export AddressSpace, Avi Kivity, 2012/10/03
[Qemu-devel] [RFC v1 07/22] memory: maintain a list of address spaces, Avi Kivity, 2012/10/03
[Qemu-devel] [RFC v1 08/22] memory: provide defaults for MemoryListener operations, Avi Kivity, 2012/10/03