[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir |
Date: |
Wed, 3 Oct 2012 16:00:58 -0300 |
On Wed, 03 Oct 2012 20:56:31 +0200
Paolo Bonzini <address@hidden> wrote:
> Il 03/10/2012 20:53, Luiz Capitulino ha scritto:
> > On Wed, 03 Oct 2012 20:32:21 +0200
> > Paolo Bonzini <address@hidden> wrote:
> >
> >> Il 03/10/2012 19:24, Luiz Capitulino ha scritto:
> >>> Defaults to /var/run.
> >>
> >> Please add instead --localstatedir (defaulting to ${prefix}/var), and
> >> make the guest agent's directory /run inside that one. Packagers
> >> already know to override --localstatedir=/var, in some cases macros even
> >> do it automatically.
> >
> > Well, that was my first version but I discarded it for two reasons.
> >
> > First, --localstatedir is a host-side setting but qemu-ga is not supposed to
> > run in the host. What if I want a different setting for guests?
>
> Then you should build twice, like you do when the guest is a completely
> different OS.
Fine with me if this is acceptable.
> > Second, having /run appended to --localstatedir (or whatever we choose) may
> > have a bad effect if qemu is built with --localstatedir=, where qemu-ga's
> > state will be "/run" (good for Fedora, but might not be good for other
> > distros or other unixes).
>
> I'm not sure I follow, it would be --localstatedir=/var usually. Even
> Fedora would not use --localstatedir=.
Which part you didn't follow, that no one would build with --localstatedir=
or what is the problem if this is done?
If it's the former, then I buy that argument and will change the series.
[Qemu-devel] [PATCH 3/3] qemu-ga: use state dir from CONFIG_QEMUGA_STATEDIR, Luiz Capitulino, 2012/10/03
[Qemu-devel] [PATCH 1/3] configure: guest_agent -> qemuga, Luiz Capitulino, 2012/10/03
Re: [Qemu-devel] [PATCH 0/3] qemu-ga: change default state dir to /var/run, Paolo Bonzini, 2012/10/03