[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch 5/6] Emulate qemu-kvms drive parameter boot=on|o
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [patch 5/6] Emulate qemu-kvms drive parameter boot=on|off |
Date: |
Wed, 03 Oct 2012 09:43:20 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Marcelo Tosatti <address@hidden> writes:
> Commit 841280b6c224ea2c6edc2f5afc2add513c85181d from qemu-kvm.git.
>
> From: Jan Kiszka <address@hidden>
>
> We do not want to maintain this option forever. It will be removed after
> a grace period of a few releases. So warn the user that this option has
> no effect and will become invalid soon.
>
> Signed-off-by: Marcelo Tosatti <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Regards,
Anthony Liguori
>
> Index: qemu-compat-kvm/blockdev.c
> ===================================================================
> --- qemu-compat-kvm.orig/blockdev.c
> +++ qemu-compat-kvm/blockdev.c
> @@ -432,6 +432,12 @@ DriveInfo *drive_init(QemuOpts *opts, in
> return NULL;
> }
>
> + if (qemu_opt_get(opts, "boot") != NULL) {
> + fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and will be "
> + "ignored. Future versions will reject this parameter. Please
> "
> + "update your scripts.\n");
> + }
> +
> on_write_error = BLOCK_ERR_STOP_ENOSPC;
> if ((buf = qemu_opt_get(opts, "werror")) != NULL) {
> if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO && type
> != IF_NONE) {
> Index: qemu-compat-kvm/qemu-config.c
> ===================================================================
> --- qemu-compat-kvm.orig/qemu-config.c
> +++ qemu-compat-kvm/qemu-config.c
> @@ -114,6 +114,10 @@ static QemuOptsList qemu_drive_opts = {
> .name = "copy-on-read",
> .type = QEMU_OPT_BOOL,
> .help = "copy read data from backing file into image file",
> + },{
> + .name = "boot",
> + .type = QEMU_OPT_BOOL,
> + .help = "(deprecated, ignored)",
> },
> { /* end of list */ }
> },
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to address@hidden
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Aurelien Jarno, 2012/10/03
[Qemu-devel] [patch 1/6] cirrus_vga: allow configurable vram size, Marcelo Tosatti, 2012/10/03
[Qemu-devel] [patch 5/6] Emulate qemu-kvms drive parameter boot=on|off, Marcelo Tosatti, 2012/10/03
- Re: [Qemu-devel] [patch 5/6] Emulate qemu-kvms drive parameter boot=on|off,
Anthony Liguori <=
[Qemu-devel] [patch 3/6] Use machine options to emulate -no-kvm-pit, Marcelo Tosatti, 2012/10/03
Re: [Qemu-devel] [patch 0/6] qemu-kvm compat, Anthony Liguori, 2012/10/03