[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system |
Date: |
Fri, 28 Sep 2012 09:52:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 28/09/2012 05:04, Wenchao Xia ha scritto:
>>>>> +$(LIBQBLOCK_TEST_DIR):
>>>>> + @echo "Make libqblock test directory"
>>>>> + mkdir $(LIBQBLOCK_TEST_DIR)
>>>>
>>>> You can leave the files in tests/ directly, and avoid this as well.
>>> Having a new directory will make clean easier, otherwise the script
>>> will need to know each image file names created, whose filename are
>>> generated in test C code at runtime.
>>
>> If you want a subdirectory for images, you can create it in the test
>> code.
>>
> My original idea is creating and deleting them in C test code, but I
> found that there is many "assert" in the code, which may cause the clean
> step missing. So I think it is simpler to clean them in Makefile, make
> sure the temporal files are deleted.
Yes, you can mkdir() in the test code, and delete the whole directory
from the Makefile.
Paolo
- Re: [Qemu-devel] [PATCH V4 2/5] libqblock type defines, (continued)
[Qemu-devel] [PATCH V4 4/5] libqblock test build system, Wenchao Xia, 2012/09/26
[Qemu-devel] [PATCH V4 5/5] libqblock test example, Wenchao Xia, 2012/09/26
[Qemu-devel] [PATCH V4 3/5] libqblock API, Wenchao Xia, 2012/09/26