[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/6] QAPI: add command for live block commit,
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/6] QAPI: add command for live block commit, 'block-commit' |
Date: |
Thu, 27 Sep 2012 14:01:04 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/27/2012 01:57 PM, Eric Blake wrote:
> On 09/27/2012 11:29 AM, Jeff Cody wrote:
>> The command for live block commit is added, which has the following
>> arguments:
>>
>> device: the block device to perform the commit on (mandatory)
>> base: the base image to commit into; optional (if not specified,
>> it is the underlying original image)
>> top: the top image of the commit - all data from inside top down
>> to base will be committed into base (mandatory for now; see
>> note, below)
>>
>
>> +++ b/qmp-commands.hx
>> @@ -792,6 +792,12 @@ EQMP
>> },
>>
>> {
>> + .name = "block-commit",
>> + .args_type = "device:B,base:s?,top:s?,speed:o?",
>
> s/top:s?/top:s/ now that top is mandatory.
>
Right, forgot the hx file. Although, QAPI catches it just fine
regardless of the hx file... but I will spin that really quick
(hopefully that is the only change required), unless Kevin wants to do
it when he pulls it into his branch.
- [Qemu-devel] [PATCH v3 0/6] Live block commit, Jeff Cody, 2012/09/27
- [Qemu-devel] [PATCH v3 1/6] block: add support functions for live commit, to find and delete images., Jeff Cody, 2012/09/27
- [Qemu-devel] [PATCH v3 2/6] block: add live block commit functionality, Jeff Cody, 2012/09/27
- [Qemu-devel] [PATCH v3 3/6] blockdev: rename block_stream_cb to a generic block_job_cb, Jeff Cody, 2012/09/27
- [Qemu-devel] [PATCH v3 4/6] block: helper function, to find the base image of a chain, Jeff Cody, 2012/09/27
- [Qemu-devel] [PATCH v3 5/6] QAPI: add command for live block commit, 'block-commit', Jeff Cody, 2012/09/27
- [Qemu-devel] [PATCH v3 6/6] qemu-iotests: add initial tests for live block commit, Jeff Cody, 2012/09/27
- Re: [Qemu-devel] [PATCH v3 0/6] Live block commit, Eric Blake, 2012/09/27
- Re: [Qemu-devel] [PATCH v3 0/6] Live block commit, Kevin Wolf, 2012/09/28