[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/45] block: fix documentation of block_job_
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/45] block: fix documentation of block_job_cancel_sync |
Date: |
Thu, 27 Sep 2012 14:13:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 27.09.2012 14:08, schrieb Paolo Bonzini:
> Il 27/09/2012 14:03, Kevin Wolf ha scritto:
>>>> /**
>>>> - * block_job_cancel:
>>>> + * block_job_cancel_sync:
>>>> * @job: The job to be canceled.
>>>> *
>>>> - * Asynchronously cancel the job and wait for it to reach a quiescent
>>>> + * Synchronously cancel the job and wait for it to reach a quiescent
>>>> * state. Note that the completion callback will still be called
>>>> * asynchronously, hence it is *not* valid to call #bdrv_delete
>>>> * immediately after #block_job_cancel_sync. Users of block jobs
>> I still don't agree with the s/Async/Sync/, in my opinion it contradicts
>> the rest of the comment. If it did cancel the job synchronously, then
>> the job would be immediately completed, and there would be no need to
>> wait for a quiescent state nor would the completion callback occur later.
>
> Now that I read it again, the comment is obsolete.
>
> block_job_cancel_sync stalls until block_job_cancel_cb is called, and
> that calls the completion callback.
Okay. Best you rephrase the whole comment then instead of changing just
one word.
Kevin
- [Qemu-devel] [PATCH v2 00/45] Block job improvements for 1.3, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 02/45] blockdev: rename block_stream_cb to a generic block_job_cb, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 04/45] block: move job APIs to separate files, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 05/45] block: add block_job_query, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 06/45] block: add support for job pause/resume, Paolo Bonzini, 2012/09/26