[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/7] block: add live block commit functionali
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/7] block: add live block commit functionality |
Date: |
Tue, 25 Sep 2012 13:05:17 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 09/25/2012 12:58 PM, Jeff Cody wrote:
> On 09/25/2012 02:12 PM, Eric Blake wrote:
>> On 09/25/2012 10:29 AM, Jeff Cody wrote:
>>> This adds the live commit coroutine. This iteration focuses on the
>>> commit only below the active layer, and not the active layer itself.
>>>
>> I think you are missing a check here that base is on the backing chain
>> of top. See also my comments to 5/7.
>>
>
> Did you mean your comments on 6/7 (or am I missing an email)?
Shoot. You're right, and I messed myself up by reviewing out of order :)
>
> This does get partially validated in patch 5/7, in the
> qmp_block_commit() handler - both base and top are verified to be in the
> chain 'bs'. What is not validated, however, is that you did not swap
> your 'top' and 'base' arguments. I'll add a check here for that, to
> make sure that base is reachable from overlay_bs.
At any rate, it sounds like I got my point across, in spite of myself.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/7] Live block commit, Jeff Cody, 2012/09/25
- [Qemu-devel] [PATCH v2 1/7] block: add support functions for live commit, to find and delete images., Jeff Cody, 2012/09/25
- [Qemu-devel] [PATCH v2 3/7] blockdev: rename block_stream_cb to a generic block_job_cb, Jeff Cody, 2012/09/25
- [Qemu-devel] [PATCH v2 4/7] block: helper function, to find the base image of a chain, Jeff Cody, 2012/09/25
- [Qemu-devel] [PATCH v2 5/7] QAPI: add command for live block commit, 'block-commit', Jeff Cody, 2012/09/25