[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 6/7] qemu-iotests: add initial tests for live
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 6/7] qemu-iotests: add initial tests for live block commit |
Date: |
Tue, 25 Sep 2012 12:02:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 09/25/2012 10:29 AM, Jeff Cody wrote:
> Derived from the streaming test cases (030), this adds the
> following tests:
>
> 1. For the following image chain, commit [mid] into [backing],
> and use qemu-io to verify [backing] has its original data, as
> well as the data from [mid]
>
> [backing] <-- [mid] <-- [test]
>
> 2. Verifies that 'block-commit' with the 'speed' parameter sets the
> speed parameter, as reported by 'query-block-jobs'
>
> 3. Verifies that a bogus 'device' parameter to 'block-commit'
> results in error
I think you are missing a test; you should also verify that:
{ "command":"block-commit", "arguments":{
"device":"drive0", "base":"mid", "top":"backing" } }
properly fails, since 'mid' is not a backing file of 'backing'. I saw
code in patch 1/7 that bdrv_drop_intermediate() should detect the
situation, but I'm not confident enough in my reading of patch 2/7 to
know if that detection point was early enough, or whether the coroutine
stuff in 2/7 ends up corrupting 'mid' prior to failure.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 3/7] blockdev: rename block_stream_cb to a generic block_job_cb, (continued)
- [Qemu-devel] [PATCH v2 3/7] blockdev: rename block_stream_cb to a generic block_job_cb, Jeff Cody, 2012/09/25
- [Qemu-devel] [PATCH v2 4/7] block: helper function, to find the base image of a chain, Jeff Cody, 2012/09/25
- [Qemu-devel] [PATCH v2 5/7] QAPI: add command for live block commit, 'block-commit', Jeff Cody, 2012/09/25
- [Qemu-devel] [PATCH v2 6/7] qemu-iotests: add initial tests for live block commit, Jeff Cody, 2012/09/25
- Re: [Qemu-devel] [PATCH v2 6/7] qemu-iotests: add initial tests for live block commit,
Eric Blake <=
- [Qemu-devel] [PATCH v2 7/7] block: after creating a live snapshot, make old image read-only, Jeff Cody, 2012/09/25