[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/4] Separate inet_connect into inet_connect
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 2/4] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect |
|
Date: |
Mon, 24 Sep 2012 12:07:27 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 24/09/2012 11:53, Markus Armbruster ha scritto:
> ongoing
>
>> > + * @errp: set in case of an error
>> > + **/
> We usually tack function comments to the function definition, not the
> declaration. Matter of taste. I like it next to the definition,
> because that improves the comment's chances to get updated along with
> the function.
Not necessarily, see main-loop.h for example.
/me would like more of these...
Paolo
>> > +int inet_connect_opts(QemuOpts *opts, bool block, bool *in_progress,
>> > + Error **errp);
[Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect, Orit Wasserman, 2012/09/23
[Qemu-devel] [PATCH v4 4/4] Clear handler only for valid fd, Orit Wasserman, 2012/09/23