[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/4] nonblocking connect address handling cle
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/4] nonblocking connect address handling cleanup |
Date: |
Mon, 24 Sep 2012 11:54:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Orit Wasserman <address@hidden> writes:
> Changes from v3:
> - add missing parenthesis QEMU_SOCKET_RC_INPROGRESS macro
> - remove "block" from dummy_opts
> - remove in_progress from external API (inet_connect_opts and
> inet_nonblocking_connect)
> - Allocate ConnectState inside inet_connect_opts, this make the
> structure internal to qemu-sockets.c
> - fix migrate_fd_cleanup to handle invalid fd.
>
> Changes from v2:
> - remove the use of getnameinfo
> - remove errp for inet_connect_addr
> - remove QemuOpt "block"
> - fix errors in wait_for_connect
> - pass ConnectState as a parameter to allow concurrent connect ops
>
> getaddrinfo can give us a list of addresses, but we only try to
> connect to the first one. If that fails we never proceed to
> the next one. This is common on desktop setups that often have ipv6
> configured but not actually working.
> A simple way to reproduce the problem is migration:
> for the destination use -incoming tcp:0:4444, run migrate -d
> tcp:localhost:4444
> migration will fail on hosts that have both IPv4 and IPV6 address for
> localhost.
>
> To fix this, refactor address resolution code and make
> inet_nonblocking_connect
> retry connection with a different address.
Good work, I'm down to nitpicking now :)
- [Qemu-devel] [PATCH v4 0/4] nonblocking connect address handling cleanup, Orit Wasserman, 2012/09/23
- [Qemu-devel] [PATCH v4 1/4] Refactor inet_connect_opts function, Orit Wasserman, 2012/09/23
- [Qemu-devel] [PATCH v4 2/4] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect, Orit Wasserman, 2012/09/23
- [Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect, Orit Wasserman, 2012/09/23
- [Qemu-devel] [PATCH v4 4/4] Clear handler only for valid fd, Orit Wasserman, 2012/09/23
- Re: [Qemu-devel] [PATCH v4 0/4] nonblocking connect address handling cleanup, Michael S. Tsirkin, 2012/09/23
- Re: [Qemu-devel] [PATCH v4 0/4] nonblocking connect address handling cleanup,
Markus Armbruster <=