Re: [Qemu-devel] [PATCH 13/13] tcg: Fix !USE_DIRECT_JUMP

[Stefan Weil]

Am 17.09.2012 17:50, schrieb Andreas Färber:
> Am 17.09.2012 17:28, schrieb Richard Henderson:
> > Commit 6375e09e changed the type of TranslationBlock.tb_next,
> > but failed to change the type of TCGContext.tb_next.
> >
> > Signed-off-by: Richard Henderson<address@hidden>
>
> Reviewed-by: Andreas Färber<address@hidden>
>
> /-F
>
> > ---
> >   tcg/tcg.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tcg/tcg.h b/tcg/tcg.h
> > index 7a72729..21016ec 100644
> > --- a/tcg/tcg.h
> > +++ b/tcg/tcg.h
> > @@ -343,7 +343,7 @@ struct TCGContext {
> >
> >       /* goto_tb support */
> >       uint8_t *code_buf;
> > -    unsigned long *tb_next;
> > +    uintptr_t *tb_next;
> >       uint16_t *tb_next_offset;
> >       uint16_t *tb_jmp_offset; /* != NULL if USE_DIRECT_JUMP */

Thanks for fixing and reviewing this issue.

I expect problems caused by the wrong old code for w64 hosts
when QEMU is run with more than 4 GiB (that's a rare scenario
because it is much slower than QEMU with kvm on Linux).

All UNIX/Linux based hosts and also w32 hosts are unharmed.

Nevertheless I suggest to apply the patch to QEMU 1.2 as well.

Regards

Stefan Weil