Re: [Qemu-devel] [PATCH v2 0/3]: qmp: send-key: accept key codes in hex

[Eric Blake]

On 09/21/2012 08:55 AM, Luiz Capitulino wrote:
> o v2
> 
>  - re-write some commit logs
>  - fix a possible issue with error handling in patch 2/3
> 
> This actually fixes a regression introduced by the qapi conversion,
> please refer to patch 2/3 for details.
> 
> It's also important to note that this series changes the QMP
> interface for the send-key command, but this shouldn't be a problem
> as we're still in development phase.
> 
>  hmp.c            | 43 +++++++++++++++++++++-----------
>  input.c          | 75 
> ++++++++++++++++++++++++++++----------------------------
>  qapi-schema.json | 19 +++++++++++---
>  3 files changed, 83 insertions(+), 54 deletions(-)

Series:
Reviewed-by: Eric Blake <address@hidden>

However, I have a bikeshed question on patch 2 that may require a respin.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature