[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/7] SCSI: Standard INQUIRY data should report HiSup
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 7/7] SCSI: Standard INQUIRY data should report HiSup flag as set. |
Date: |
Fri, 21 Sep 2012 16:52:49 +0200 |
From: Ronnie Sahlberg <address@hidden>
QEMU as far as I know only reports LUN numbers using the modes that
are described in SAM4.
As such, since all LUN numbers generated by the SCSI emulation in QEMU
follow SAM4, we should set the HiSup bit in the standard INQUIRY data
to indicate such.
>From SAM4:
4.6.3 LUNs overview
All LUN formats described in this standard are hierarchical in
structure even when only a single level in that hierarchy is used.
The HISUP bit shall be set to one in the standard INQUIRY data
(see SPC-4) when any LUN format described in this standard is used.
Non-hierarchical formats are outside the scope of this standard.
Signed-off-by: Ronnie Sahlberg <address@hidden>
---
hw/scsi-disk.c | 2 +-
1 file modificato, 1 inserzione(+). 1 rimozione(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 4ffca7a..95e9158 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -678,7 +678,7 @@ static int scsi_disk_emulate_inquiry(SCSIRequest *req,
uint8_t *outbuf)
* is actually implemented, but we're good enough.
*/
outbuf[2] = 5;
- outbuf[3] = 2; /* Format 2 */
+ outbuf[3] = 2 | 0x10; /* Format 2, HiSup */
if (buflen > 36) {
outbuf[4] = buflen - 5; /* Additional Length = (Len - 1) - 4 */
--
1.7.12
- [Qemu-devel] [PULL 0/7] SCSI patches for 2012-09-21, Paolo Bonzini, 2012/09/21
- [Qemu-devel] [PATCH 2/7] iSCSI: We dont need to explicitely call qemu_notify_event() any more, Paolo Bonzini, 2012/09/21
- [Qemu-devel] [PATCH 3/7] scsi-disk: introduce check_lba_range, Paolo Bonzini, 2012/09/21
- [Qemu-devel] [PATCH 4/7] scsi-disk: fix check for out-of-range LBA, Paolo Bonzini, 2012/09/21
- [Qemu-devel] [PATCH 1/7] iSCSI: We need to support SG_IO also from iscsi_ioctl(), Paolo Bonzini, 2012/09/21
- [Qemu-devel] [PATCH 6/7] scsi-disk: use scsi_data_cdb_length, Paolo Bonzini, 2012/09/21
- [Qemu-devel] [PATCH 5/7] scsi: introduce scsi_cdb_length and scsi_data_cdb_length, Paolo Bonzini, 2012/09/21
- [Qemu-devel] [PATCH 7/7] SCSI: Standard INQUIRY data should report HiSup flag as set.,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL 0/7] SCSI patches for 2012-09-21, Anthony Liguori, 2012/09/25