Re: [Qemu-devel] [PATCH] pflash: Avoid warnings from coverity

[Peter Maydell]

On 19 September 2012 21:51, Stefan Weil <address@hidden> wrote:
> Am 19.09.2012 18:45, schrieb Peter Maydell:
>> ...shouldn't we be propagating the write error up to the guest?
>> It feels like this change is just silencing the coverity error
>> without actually fixing the underlying problem.

> As far as I know, there is no concept how a flash memory
> can report a write error. Flash memory which cannot be
> written is unusable.

Just looking at the callers of the pflash_update() function,
they have cases where they set bits in the status register
for errors, so there clearly is a mechanism for reporting
errors back to the guest.

-- PMM