[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/12] qapi: add socket address types
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 06/12] qapi: add socket address types |
Date: |
Wed, 19 Sep 2012 11:20:28 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/19/2012 08:31 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> qapi-schema.json | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file modificato, 53 inserzioni(+)
>
> ##
> +# @IPSocketAddress
> +#
> +# Captures the destination address of an IP socket
Given the presence of @to, would this read better as:
IP socket or socket range
> +#
> +# @host: host part of the address
> +#
> +# @port: port part of the address, or lowest port if @to is present
> +#
> +# @to: highest port to try
> +#
> +# @ipv4: whether to accept IPv4 addresses, default try both IPv4 and IPv6
> +# #optional
Isn't the #optional supposed to occur first after the colon, as in:
@ipv4: #optional whether to accept IPv4...
> +#
> +# @ipv6: whether to accept IPv6 addresses, default try both IPv4 and IPv6
> +# #optional
> +#
> +# Since 1.3
> +##
> +{ 'type': 'IPSocketAddress',
> + 'data': {
> + 'host': 'str',
> + 'port': 'str',
> + '*to': 'uint16',
Why is 'port' a string, but 'to' a uint16? Shouldn't they both be uint16?
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 03/12] qapi: do not protect enum values from namespace pollution, (continued)
[Qemu-devel] [PATCH 06/12] qapi: add socket address types, Paolo Bonzini, 2012/09/19
- Re: [Qemu-devel] [PATCH 06/12] qapi: add socket address types,
Eric Blake <=
[Qemu-devel] [PATCH 07/12] qemu-sockets: add error propagation to inet_parse, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 08/12] qemu-sockets: add error propagation to Unix socket functions, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 12/12] qemu-sockets: add socket_listen, socket_connect, socket_parse, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 13/12] block: add close notifiers, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 14/12] qmp: add NBD server commands, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 10/12] qemu-sockets: move block from QemuOpts to arguments, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 11/12] qemu-sockets: add block and in_progress arguments to unix_connect_opts, Paolo Bonzini, 2012/09/19