[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 15/16] qcow2: Cancel COW when overwritten
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [RFC PATCH 15/16] qcow2: Cancel COW when overwritten |
Date: |
Tue, 18 Sep 2012 17:02:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 18.09.2012 16:44, schrieb Paolo Bonzini:
> Il 18/09/2012 13:40, Kevin Wolf ha scritto:
>> + qemu_co_mutex_unlock(&s->lock);
>> + qemu_co_rwlock_wrlock(&m->l2_writeback_lock);
>
> Can anybody else take the lock as reader again at this point? If not, I
> wonder if this is more clear if you write it as a CoQueue.
This isn't "let one writer complete, then wake up n readers" (which
would indeed be represented more naturally as CoQueue), but rather "let
n readers complete, then wake up one writer".
Kevin
- Re: [Qemu-devel] [RFC PATCH 09/16] qcow2: Move COW and L2 update into own coroutine, (continued)