Re: [Qemu-devel] [RFC PATCH 09/10] i386: move TCG functions out of helper.o, non-TCG functions to cpu.o

[Paolo Bonzini]

Il 17/09/2012 19:12, Peter Maydell ha scritto:
>> > +
>> > +    if (env->watchpoint_hit) {
>> > +        if (env->watchpoint_hit->flags & BP_CPU) {
>> > +            env->watchpoint_hit = NULL;
>> > +            if (check_hw_breakpoints(env, 0))
>> > +                raise_exception(env, EXCP01_DB);
>> > +            else
>> > +                cpu_resume_from_signal(env, NULL);
>> > +        }
>> > +    } else {
>> > +        QTAILQ_FOREACH(bp, &env->breakpoints, entry)
>> > +            if (bp->pc == env->eip) {
>> > +                if (bp->flags & BP_CPU) {
>> > +                    check_hw_breakpoints(env, 1);
>> > +                    raise_exception(env, EXCP01_DB);
>> > +                }
>> > +                break;
>> > +            }
>> > +    }
>> > +}
> Why does moving this from one helper.c file to another let us
> remove *helper.c from the non-TCG build?

It's *_helper.c, i.e. helper.c remains in the non-TCG build.  But this
function has a dependency on excp_helper.c, and is not used in the
non-TCG case, so move it where it belongs.

Paolo