[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] allow make {dist, }clean work w/out configure
From: |
Mike Frysinger |
Subject: |
Re: [Qemu-devel] [PATCH] allow make {dist, }clean work w/out configure |
Date: |
Sun, 16 Sep 2012 16:03:23 -0400 |
User-agent: |
KMail/1.13.7 (Linux/3.5.0; KDE/4.6.5; x86_64; ; ) |
On Sunday 16 September 2012 05:52:47 Paolo Bonzini wrote:
> Il 16/09/2012 02:30, Mike Frysinger ha scritto:
> > There's no reason to require configure to run before running a clean
> > target, so check MAKECMDGOALS before.
> >
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -14,9 +14,11 @@ config-host.mak: $(SRC_PATH)/configure
> > @sed -n "/.*Configured with/s/[^:]*: //p" $@ | sh
> > else
> > config-host.mak:
> > +ifeq ($(findstring clean,$(MAKECMDGOALS)),)
>
> Please use instead:
>
> ifneq ($(filter-out %clean,$(MAKECMDGOALS)),)
>
> so that "make clean all" still gives error.
that breaks `make` though. or rather, `make` no longer errors out. need to
make it a little more complicated to handle this.
-mike
signature.asc
Description: This is a digitally signed message part.