[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] Refactor inet_connect_opts function
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] Refactor inet_connect_opts function |
Date: |
Fri, 14 Sep 2012 10:37:47 +0300 |
On Thu, Sep 13, 2012 at 07:52:35PM +0300, Orit Wasserman wrote:
> >> + for (e = res; e != NULL; e = e->ai_next) {
> >> + sock = inet_connect_addr(e, block, in_progress, errp);
> >> + if (in_progress && *in_progress) {
> >> + return sock;
> >
> > Doesn't this leak res?
> Actually it doesn't after patch 3 wait_for_connect is the one freeing res.
> is it OK to leave it as is ?
>
> Orit
We can't avoid breaking bisect sometimes but let's not do this intentionally.
--
MST
[Qemu-devel] [PATCH v2 2/3] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect, Orit Wasserman, 2012/09/12