[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 19/47] block: add bdrv_query_info
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 19/47] block: add bdrv_query_info |
|
Date: |
Tue, 11 Sep 2012 15:07:05 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 24.07.2012 13:03, schrieb Paolo Bonzini:
> Extract it out of the implementation of "info block".
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> block.c | 104
> +++++++++++++++++++++++++++++++--------------------------------
> block.h | 1 +
> 2 files changed, 53 insertions(+), 52 deletions(-)
The refactoring looks correct, but why do you put the function between
qmp_query_blockstat and qmp_query_blockstats? If you put it next to
qmp_query_block, both functions pairs stay closer together.
Kevin
- Re: [Qemu-devel] [PATCH 19/47] block: add bdrv_query_info,
Kevin Wolf <=