Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable

[Paolo Bonzini]

Il 10/09/2012 18:02, Anthony Liguori ha scritto:
> I think the wiring is wrong here.  Why would a device assert the wakeup
> reason?
> 
> I assume on bare metal, the device asserts a single line and then
> something devices how to treat the output from a given device.
> 
> IOW, shouldn't it be something more like, SerialState exports a qemu_irq
> and then the machine code decides whether to route that irq to a call to
> qemu_system_wakeup().  Then depending on whether this is coming from
> serial[1], determines which reason is used.

But the only way to do it, that works for -device, is to look at the
SerialState's iobase.  So it would still be a hack, only in ACPI rather
than isa-serial.c.

Paolo