[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assign
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment |
Date: |
Sun, 09 Sep 2012 17:13:56 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/06/2012 11:44 AM, Jan Kiszka wrote:
> On 2012-08-30 20:30, Jan Kiszka wrote:
>> This adds PCI device assignment for i386 targets using the classic KVM
>> interfaces. This version is 100% identical to what is being maintained
>> in qemu-kvm for several years and is supported by libvirt as well. It is
>> expected to remain relevant for another couple of years until kernels
>> without full-features and performance-wise equivalent VFIO support are
>> obsolete.
>>
>> A refactoring to-do that should be done in-tree is to model MSI and
>> MSI-X support via the generic PCI layer, similar to what VFIO is already
>> doing for MSI-X. This should improve the correctness and clean up the
>> code from duplicate logic.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>>
>> Changes in v3:
>> - addressed comment by Peter (changed device name to kvm-pci-assign +
>> alias)
>> - addressed (most) comments by Michael
>> - fixed INT pin regression
>
> Does someone _disagree_ that there are no open (and reasonably solvable)
> issues and that this can now be merged through uq/master?
Is patch 4 the only one that is at v3, and the rest are to be taken from
the original posting?
--
error compiling committee.c: too many arguments to function