[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2)
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2) |
Date: |
Wed, 05 Sep 2012 22:45:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-09-05 22:04, Stefan Weil wrote:
> Am 05.09.2012 21:18, schrieb Anthony Liguori:
>> This is minimalistic and just contains the basic widget
>> infrastructure. The GUI
>> consists of a menu and a GtkNotebook. To start with, the notebook has
>> its tabs
>> hidden which provides a UI that looks very similar to SDL with the
>> exception of
>> the menu bar.
>>
>> The menu bar allows a user to toggle the visibility of the tabs.
>> Cairo is used
>> for rendering.
>>
>> I used gtk-vnc as a reference. gtk-vnc solves the same basic problems
>> as QEMU
>> since it was originally written as a remote display for QEMU. So for
>> the most
>> part, the approach to rendering and keyboard handling should be pretty
>> solid for
>> GTK.
>>
>> Signed-off-by: Anthony Liguori<address@hidden>
>> ---
>> v1 -> v2
>> - add gtk-vnc license
>> - fix key propagation
>> ---
>> Makefile | 2 +
>> configure | 25 +++-
>> console.h | 4 +
>> sysemu.h | 1 +
>> ui/Makefile.objs | 1 +
>> ui/gtk.c | 572
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> 6 files changed, 604 insertions(+), 1 deletions(-)
>> create mode 100644 ui/gtk.c
>>
>
> Hi Anthony,
>
> I tested the previous version of your series and noticed that the
> menu accelerators (especially for file/quit) which are still part of
> this new patch are a bad idea.
>
> Just run a system emulation, start some GUI program in the emulation
> and press Ctrl-Q: you won't terminate the GUI program, but terminate
> QEMU!
Yep, standard accelerators must go, definitely while the input is grabbed.
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 5/7] gtk: add support for screen scaling and full screen (v3), (continued)
- [Qemu-devel] [PATCH 5/7] gtk: add support for screen scaling and full screen (v3), Anthony Liguori, 2012/09/05
- [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2), Anthony Liguori, 2012/09/05
- Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2), Blue Swirl, 2012/09/05
- Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2), Eric Blake, 2012/09/05
- Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2), Anthony Liguori, 2012/09/05
- Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2), Blue Swirl, 2012/09/05
- Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2), Anthony Liguori, 2012/09/05
- Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2), Blue Swirl, 2012/09/08
Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2), Stefan Weil, 2012/09/05
Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2), Jan Kiszka, 2012/09/05
[Qemu-devel] [PATCH 3/7] gtk: add virtual console support (v2), Anthony Liguori, 2012/09/05
[Qemu-devel] [PATCH 6/7] gtk: add translation support, Anthony Liguori, 2012/09/05
[Qemu-devel] [PATCH 4/7] gtk: add support for input grabbing (v2), Anthony Liguori, 2012/09/05