[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 10/19] json-parser: Fix potential NULL pointer segfa
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 10/19] json-parser: Fix potential NULL pointer segfault |
Date: |
Wed, 5 Sep 2012 15:58:37 -0300 |
From: Stefan Weil <address@hidden>
Report from smatch:
json-parser.c:474 parse_object(62) error: potential null derefence 'dict'.
json-parser.c:553 parse_array(75) error: potential null derefence 'list'.
Label 'out' in json-parser.c can be called with list == NULL
which is passed to QDECREF.
Modify QDECREF to handle a NULL argument (inline function qobject_decref
already handles them, too).
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>
---
qobject.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qobject.h b/qobject.h
index d42386d..9124649 100644
--- a/qobject.h
+++ b/qobject.h
@@ -71,7 +71,7 @@ typedef struct QObject {
/* High-level interface for qobject_decref() */
#define QDECREF(obj) \
- qobject_decref(QOBJECT(obj))
+ qobject_decref(obj ? QOBJECT(obj) : NULL)
/* Initialize an object to default values */
#define QOBJECT_INIT(obj, qtype_type) \
--
1.7.11.2.249.g31c7954.dirty
- [Qemu-devel] [PULL 00/19]: QMP queue, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 01/19] Add support for pretty-printing response in qmp-shell, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 02/19] fix doc of using raw values with sendkey, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 03/19] monitor: rename keyname '<' to 'less', Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 04/19] hmp: rename arguments, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 05/19] qapi: generate list struct and visit_list for enum, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 06/19] qapi: add the QKeyCode enum, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 07/19] monitor: move key_defs[] table and introduce two help functions, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 10/19] json-parser: Fix potential NULL pointer segfault,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 08/19] qapi: convert sendkey, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 09/19] qapi: Fix potential NULL pointer segfault, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 11/19] error: add error_setg(), Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 14/19] vga: ppm_save(): add error handling, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 13/19] qapi: convert screendump, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 15/19] omap_lcdc: rename ppm_save() to omap_ppm_save(), Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 12/19] console: vga_hw_screen_dump_ptr: take Error argument, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 19/19] tcx: tcx_screen_dump(): add error handling, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 17/19] g364fb: g364fb_screen_dump(): add error handling, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 16/19] omap_lcdc: omap_ppm_save(): add error handling, Luiz Capitulino, 2012/09/05