Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

[Richard Henderson]

On 09/02/2012 10:33 AM, Blue Swirl wrote:
> +/* fpu_helper.c */
> +uint32_t set_cc_f32(float32 v1, float32 v2);
> +uint32_t set_cc_f64(float64 v1, float64 v2);
> +uint32_t set_cc_nz_f32(float32 v);
> +uint32_t set_cc_nz_f64(float64 v);
> +

I think that the CC handling should stay together, regardless of FPU-ness.
These functions are quite small and can be usefully inlined by the compiler.

OTOH, this is much easier to do with my translate.c rewrite, so maybe I'll
just take responsibility for moving them back...


r~