[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-arm: Fix potential buffer overflow
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-arm: Fix potential buffer overflow |
|
Date: |
Tue, 4 Sep 2012 15:19:27 +0100 |
On 4 September 2012 06:35, Stefan Weil <address@hidden> wrote:
> Report from smatch:
>
> target-arm/helper.c:651 arm946_prbs_read(6) error:
> buffer overflow 'env->cp15.c6_region' 8 <= 8
> target-arm/helper.c:661 arm946_prbs_write(6) error:
> buffer overflow 'env->cp15.c6_region' 8 <= 8
>
> c7_region is an array with 8 elements, so the index must be less than 8.
>
> Signed-off-by: Stefan Weil <address@hidden>
Nice catch, dumb bug I introduced in the conversion to
CPRegInfo in commit 06d76f319f.
Reviewed-by: Peter Maydell <address@hidden>
-- PMM