[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/21] target-arm: switch to AREG0 free mode
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 16/21] target-arm: switch to AREG0 free mode |
Date: |
Mon, 3 Sep 2012 20:10:15 +0000 |
On Mon, Sep 3, 2012 at 7:54 PM, Peter Maydell <address@hidden> wrote:
> On 3 September 2012 19:58, Blue Swirl <address@hidden> wrote:
>> On Mon, Sep 3, 2012 at 12:03 AM, Peter Maydell <address@hidden> wrote:
>>> On 3 September 2012 01:01, Peter Maydell <address@hidden> wrote:
>>> That's quite hard to cross-reference when the patch is this big.
>>> I think it would be helpful if you could split it up into patches
>>> touching smaller groups of helpers at once rather than having a
>>> single patch that does them all at once.
>>
>> For x86, Sparc and s390x I used the approach of splitting op_helper.c
>> to smaller files first. I didn't do it for ARM since
>> target-arm/op_helper.c is alread pretty small (<500 lines). It could
>> be split to saturating ops, condition code setting arithmetic ops and
>> misc ops, between 100 and 200 lines each. Would that be OK?
>
> I don't want the *file* split, I'd just like to see this *patch*
> as 4 or 5 separate patches, not one big one.
While converting, it's easier to work on whole files but maybe the
resulting patch can be still split.
>
> (Patch-splitting is a personal preference thing; I generally favour
> lots of little patches over big ones.)
That's just common sense. The conversion logic is just not very helpful here.
>
> thanks
> -- PMM
- [Qemu-devel] [PATCH 07/21] target-s390x: avoid AREG0 for FPU helpers, (continued)
- [Qemu-devel] [PATCH 07/21] target-s390x: avoid AREG0 for FPU helpers, Blue Swirl, 2012/09/02
- [Qemu-devel] [PATCH 09/21] target-s390x: avoid AREG0 for condition code helpers, Blue Swirl, 2012/09/02
- [Qemu-devel] [PATCH 10/21] target-s390x: avoid AREG0 for misc helpers, Blue Swirl, 2012/09/02
- [Qemu-devel] [PATCH 12/21] target-s390x: split helper.c, Blue Swirl, 2012/09/02
- [Qemu-devel] [PATCH 14/21] target-m68k: switch to AREG0 free mode, Blue Swirl, 2012/09/02
- [Qemu-devel] [PATCH 16/21] target-arm: switch to AREG0 free mode, Blue Swirl, 2012/09/02
Re: [Qemu-devel] [PATCH 16/21] target-arm: switch to AREG0 free mode, Peter Maydell, 2012/09/03
[Qemu-devel] [PATCH 17/21] target-microblaze: switch to AREG0 free mode, Blue Swirl, 2012/09/02
[Qemu-devel] [PATCH 18/21] target-cris: switch to AREG0 free mode, Blue Swirl, 2012/09/02